From fed08a0f45294d00860fa0a512d3cf8b58becc0e Mon Sep 17 00:00:00 2001
From: codetypes <codetypes@gmail.com>
Date: Wed, 13 Mar 2024 00:28:37 +0800
Subject: [PATCH] double click to edit subtree

---
 common/Utils.ts                     |  27 +-------
 main-process/AppMenu.ts             |  28 ++++----
 main-process/MainProcess.tsx        |  14 +++-
 render-process/Editor/NodePanel.tsx |  59 +++++++++++-----
 render-process/Editor/index.tsx     | 100 +++++++++++++++++++---------
 render-process/RegisterNode.ts      |  31 ++++-----
 render-process/TreeTabs.tsx         |  16 ++++-
 sample/workdir/monster.json         |   1 +
 sample/workdir/subtree2.json        |   8 +++
 9 files changed, 176 insertions(+), 108 deletions(-)

diff --git a/common/Utils.ts b/common/Utils.ts
index 3c43d53..2f5d4b3 100644
--- a/common/Utils.ts
+++ b/common/Utils.ts
@@ -1,9 +1,8 @@
-import { TreeGraph } from "@antv/g6";
-import * as path from "path";
+import { message } from "antd";
 import * as fs from "fs";
+import * as path from "path";
 import Settings from "../main-process/Settings";
 import { BehaviorNodeModel, BehaviorTreeModel, GraphNodeModel } from "./BehaviorTreeModel";
-import { message } from "antd";
 
 interface INodeDataLike {
     path?: string;
@@ -165,28 +164,6 @@ export const createFileData = (gNode: GraphNodeModel, includeSubtree?: boolean)
     return nodeData;
 };
 
-export const findParent = (graph: TreeGraph, node: GraphNodeModel) => {
-    if (node.parent) {
-        return graph.findDataById(node.parent);
-    } else {
-        return null;
-    }
-};
-
-export const isAncestor = (
-    graph: TreeGraph,
-    ancestor: GraphNodeModel,
-    node: GraphNodeModel
-): boolean => {
-    if (ancestor.id === node.parent) {
-        return true;
-    } else if (node.parent) {
-        return isAncestor(graph, ancestor, graph.findDataById(node.parent) as GraphNodeModel);
-    } else {
-        return false;
-    }
-};
-
 export const getRemoteSettings = () => {
     return require("@electron/remote").getGlobal("settings") as Settings;
 };
diff --git a/main-process/AppMenu.ts b/main-process/AppMenu.ts
index 6d7b5ea..354a5c1 100644
--- a/main-process/AppMenu.ts
+++ b/main-process/AppMenu.ts
@@ -55,7 +55,7 @@ export default class AppMenu {
             submenu: [
                 {
                     label: "新建",
-                    accelerator: "CommandOrControl+n",
+                    accelerator: "CmdOrCtrl+n",
                     click: () => {
                         (async () => {
                             const res = await dialog.showSaveDialog({
@@ -75,7 +75,7 @@ export default class AppMenu {
                 },
                 {
                     label: "打开文件",
-                    accelerator: "CommandOrControl+O",
+                    accelerator: "CmdOrCtrl+O",
                     click: () => {
                         (async () => {
                             const res = await dialog.showOpenDialog({
@@ -103,14 +103,14 @@ export default class AppMenu {
                 { type: "separator" },
                 {
                     label: "保存",
-                    accelerator: "CommandOrControl+s",
+                    accelerator: "CmdOrCtrl+s",
                     click: () => {
                         this.webContents.send(MainEventType.SAVE);
                     },
                 },
                 {
                     label: "全部保存",
-                    accelerator: "CommandOrControl+shift+s",
+                    accelerator: "CmdOrCtrl+shift+s",
                     click: () => {
                         this.webContents.send(MainEventType.SAVE_ALL);
                     },
@@ -139,7 +139,7 @@ export default class AppMenu {
                 },
                 {
                     label: "构建",
-                    accelerator: "CommandOrControl+b",
+                    accelerator: "CmdOrCtrl+b",
                     click: async () => {
                         if (!this.buildDir) {
                             const res = await dialog.showOpenDialog({
@@ -163,17 +163,13 @@ export default class AppMenu {
             submenu: [
                 {
                     label: "撤销",
-                    accelerator: "CommandOrControl+z",
-                    click: () => {
-                        this.webContents.send(MainEventType.UNDO);
-                    },
+                    accelerator: "CmdOrCtrl+z",
+                    role: "undo",
                 },
                 {
                     label: "恢复",
-                    accelerator: "CommandOrControl+y",
-                    click: () => {
-                        this.webContents.send(MainEventType.REDO);
-                    },
+                    accelerator: process.platform === "darwin" ? "cmd+shift+z" : "ctrl+y",
+                    role: "redo",
                 },
                 { type: "separator" },
                 {
@@ -287,7 +283,7 @@ export default class AppMenu {
                 { type: "separator" },
                 {
                     label: "打开目录",
-                    accelerator: "CommandOrControl+Shift+O",
+                    accelerator: "CmdOrCtrl+Shift+O",
                     click: () => {
                         if (!this.settings.curWorkspace.getNodeConfPath()) {
                             dialog.showErrorBox("警告", "请先指定节点定义配置!");
@@ -364,7 +360,7 @@ export default class AppMenu {
             submenu: [
                 {
                     label: "热更",
-                    accelerator: "CommandOrControl+R",
+                    accelerator: "CmdOrCtrl+R",
                     click: () => {
                         this.webContents.send(MainEventType.RELOAD_SERVER);
                     },
@@ -392,7 +388,7 @@ export default class AppMenu {
                 },
                 {
                     label: "打开控制台",
-                    accelerator: "CommandOrControl+Shift+I",
+                    accelerator: "CmdOrCtrl+Shift+I",
                     click: (_, browserWindow) => {
                         browserWindow.webContents.toggleDevTools();
                     },
diff --git a/main-process/MainProcess.tsx b/main-process/MainProcess.tsx
index 94269df..19c9db6 100644
--- a/main-process/MainProcess.tsx
+++ b/main-process/MainProcess.tsx
@@ -18,12 +18,18 @@ export class MainProcess {
         nativeTheme.themeSource = "dark";
         app.on("ready", () => {
             this.createWindow();
-            electronLocalshortcut.register(this.mainWindow, "CommandOrControl+C", () => {
+            this.registerShortcut("CmdOrCtrl+C", () => {
                 this.mainWindow.webContents.send(MainEventType.COPY_NODE);
             });
-            electronLocalshortcut.register(this.mainWindow, "CommandOrControl+V", () => {
+            this.registerShortcut("CmdOrCtrl+V", () => {
                 this.mainWindow.webContents.send(MainEventType.PASTE_NODE);
             });
+            this.registerShortcut("CmdOrCtrl+Z", () => {
+                this.mainWindow.webContents.send(MainEventType.UNDO);
+            });
+            this.registerShortcut(process.platform === "darwin" ? "Cmd+Shift+Z" : "ctrl+y", () => {
+                this.mainWindow.webContents.send(MainEventType.REDO);
+            });
         });
         app.on("window-all-closed", () => {
             if (process.platform !== "darwin") {
@@ -37,6 +43,10 @@ export class MainProcess {
         });
     }
 
+    registerShortcut(accelerator: string | string[], callback: () => void) {
+        electronLocalshortcut.register(this.mainWindow, accelerator, callback);
+    }
+
     createWindow() {
         this.settings = new Settings();
         global.settings = this.settings;
diff --git a/render-process/Editor/NodePanel.tsx b/render-process/Editor/NodePanel.tsx
index 1a07ce9..79875f2 100644
--- a/render-process/Editor/NodePanel.tsx
+++ b/render-process/Editor/NodePanel.tsx
@@ -25,6 +25,7 @@ const { Item } = Form;
 const { Option } = Select;
 
 interface NodePanelProps {
+    isSubtreeNode: boolean;
     model: BehaviorNodeModel;
     settings: Settings;
     updateNode: (id: string, forceUpdate: boolean) => void;
@@ -151,7 +152,7 @@ export default class NodePanel extends React.Component<NodePanelProps> {
     };
 
     render() {
-        const { model, settings } = this.props;
+        const { model, settings, isSubtreeNode } = this.props;
         const conf = settings.getNodeConf(model.name);
         const title = conf.desc;
 
@@ -178,6 +179,7 @@ export default class NodePanel extends React.Component<NodePanelProps> {
                     </Item>
                     <Item label="节点名称" name="name">
                         <AutoComplete
+                            disabled={isSubtreeNode}
                             options={options}
                             onBlur={this.handleSubmit}
                             filterOption={(inputValue: string, option: any) => {
@@ -189,24 +191,24 @@ export default class NodePanel extends React.Component<NodePanelProps> {
                         />
                     </Item>
                     <Item label="节点说明" name="desc">
-                        <Input onBlur={this.handleSubmit} />
+                        <Input disabled={isSubtreeNode} onBlur={this.handleSubmit} />
                     </Item>
                     <Item label="调试开关" name="debug" valuePropName="checked">
-                        <Switch onChange={this.handleSubmit} />
+                        <Switch disabled={isSubtreeNode} onChange={this.handleSubmit} />
                     </Item>
                     <Item label="子树" name="path">
-                        <Input onBlur={this.handleSubmit} />
+                        <Input disabled={isSubtreeNode && !model.path} onBlur={this.handleSubmit} />
                     </Item>
                     <Markdown source={conf.doc} />
-                    {this.renderInputs(conf)}
-                    {this.renderArgs(conf)}
-                    {this.renderOutputs(conf)}
+                    {this.renderInputs(conf, isSubtreeNode)}
+                    {this.renderArgs(conf, isSubtreeNode)}
+                    {this.renderOutputs(conf, isSubtreeNode)}
                 </Form>
             </Card>
         );
     }
 
-    renderArgs(conf: BehaviorNodeTypeModel) {
+    renderArgs(conf: BehaviorNodeTypeModel, isSubtreeNode: boolean) {
         if (!conf || !conf.args || conf.args.length == 0) {
             return null;
         }
@@ -215,24 +217,41 @@ export default class NodePanel extends React.Component<NodePanelProps> {
         const normalArgs = (e: ArgsDefType) => {
             const required = e.type.indexOf("?") == -1;
             if (e.type.indexOf("string") >= 0) {
-                return <Input onBlur={this.handleSubmit} />;
+                return <Input disabled={isSubtreeNode} onBlur={this.handleSubmit} />;
             } else if (e.type.indexOf("int") >= 0) {
                 return (
                     <InputNumber
+                        disabled={isSubtreeNode}
                         precision={0}
                         style={{ width: "100%" }}
                         onBlur={this.handleSubmit}
                     />
                 );
             } else if (e.type.indexOf("float") >= 0) {
-                return <InputNumber style={{ width: "100%" }} onBlur={this.handleSubmit} />;
+                return (
+                    <InputNumber
+                        disabled={isSubtreeNode}
+                        style={{ width: "100%" }}
+                        onBlur={this.handleSubmit}
+                    />
+                );
             } else if (e.type.indexOf("boolean") >= 0) {
-                return <Switch onChange={this.handleSubmit} />;
+                return <Switch disabled={isSubtreeNode} onChange={this.handleSubmit} />;
             } else if (e.type.indexOf("code") >= 0) {
-                return <Input onBlur={this.handleSubmit} placeholder={"表达式"} />;
+                return (
+                    <Input
+                        disabled={isSubtreeNode}
+                        onBlur={this.handleSubmit}
+                        placeholder={"表达式"}
+                    />
+                );
             } else if (e.type.indexOf("enum") >= 0) {
                 return (
-                    <Select style={{ width: 120 }} onChange={this.handleSubmit}>
+                    <Select
+                        disabled={isSubtreeNode}
+                        style={{ width: 120 }}
+                        onChange={this.handleSubmit}
+                    >
                         {e.options.map((e) => {
                             return (
                                 <Option key={e.name} value={e.value}>
@@ -249,7 +268,11 @@ export default class NodePanel extends React.Component<NodePanelProps> {
         const customArgs = () => {
             return (
                 <Item name="customArgs" label="自定义" key="customArgs">
-                    <Input.TextArea onBlur={this.handleSubmit} style={{ minHeight: 100 }} />
+                    <Input.TextArea
+                        disabled={isSubtreeNode}
+                        onBlur={this.handleSubmit}
+                        style={{ minHeight: 100 }}
+                    />
                 </Item>
             );
         };
@@ -283,7 +306,7 @@ export default class NodePanel extends React.Component<NodePanelProps> {
         );
     }
 
-    renderInputs(conf: BehaviorNodeTypeModel) {
+    renderInputs(conf: BehaviorNodeTypeModel, isSubtreeNode: boolean) {
         if (!conf.input || !conf.input || conf.input.length == 0) {
             return null;
         }
@@ -296,7 +319,7 @@ export default class NodePanel extends React.Component<NodePanelProps> {
                 {conf.input.map((e, i) => {
                     return (
                         <Item label={e} name={`input.${i}`} key={`input.${i}`}>
-                            <Input onBlur={this.handleSubmit} />
+                            <Input disabled={isSubtreeNode} onBlur={this.handleSubmit} />
                         </Item>
                     );
                 })}
@@ -304,7 +327,7 @@ export default class NodePanel extends React.Component<NodePanelProps> {
         );
     }
 
-    renderOutputs(conf: BehaviorNodeTypeModel) {
+    renderOutputs(conf: BehaviorNodeTypeModel, isSubtreeNode: boolean) {
         if (!conf.output || !conf.output || conf.output.length == 0) {
             return null;
         }
@@ -316,7 +339,7 @@ export default class NodePanel extends React.Component<NodePanelProps> {
                 {conf.output.map((e, i) => {
                     return (
                         <Item label={e} name={`output.${i}`} key={`output.${i}`}>
-                            <Input onBlur={this.handleSubmit} />
+                            <Input disabled={isSubtreeNode} onBlur={this.handleSubmit} />
                         </Item>
                     );
                 })}
diff --git a/render-process/Editor/index.tsx b/render-process/Editor/index.tsx
index ecba25b..6c4f4a7 100644
--- a/render-process/Editor/index.tsx
+++ b/render-process/Editor/index.tsx
@@ -21,6 +21,7 @@ import "./Editor.css";
 export interface EditorProps {
     filepath: string;
     onChangeSaveState: (unsave: boolean) => void;
+    onOpenSubtree: (path: string) => void;
 }
 
 interface EditorState {
@@ -32,9 +33,9 @@ interface EditorState {
 export default class Editor extends React.Component<EditorProps, EditorState> {
     private ref: React.RefObject<any>;
     state: EditorState = {};
+    isInEditor: boolean = false;
 
     private graph: TreeGraph;
-    private isInEditor: boolean = false;
     private dragSrcId: string;
     private dragDstId: string;
     private autoId: number;
@@ -71,6 +72,47 @@ export default class Editor extends React.Component<EditorProps, EditorState> {
         }
     }
 
+    findParent(node: GraphNodeModel) {
+        if (node.parent) {
+            return this.graph.findDataById(node.parent) as GraphNodeModel;
+        } else {
+            return null;
+        }
+    }
+
+    findSubtree(node?: GraphNodeModel): GraphNodeModel | null {
+        if (node?.path) {
+            return node;
+        } else if (node?.parent) {
+            return this.findSubtree(this.findParent(node));
+        } else {
+            return null;
+        }
+    }
+
+    isSubtreeNode(node?: GraphNodeModel): boolean {
+        if (node?.path) {
+            return true;
+        } else if (node?.parent) {
+            return this.isSubtreeNode(this.findParent(node));
+        } else {
+            return false;
+        }
+    }
+
+    isAncestor(ancestor: GraphNodeModel, node: GraphNodeModel): boolean {
+        if (ancestor.id === node.parent) {
+            return true;
+        } else if (node.parent) {
+            return this.isAncestor(
+                ancestor,
+                this.graph.findDataById(node.parent) as GraphNodeModel
+            );
+        } else {
+            return false;
+        }
+    }
+
     componentDidMount() {
         const graph = new TreeGraph({
             container: this.ref.current,
@@ -80,28 +122,7 @@ export default class Editor extends React.Component<EditorProps, EditorState> {
             maxZoom: 2,
             // fitCenter: true,
             modes: {
-                default: [
-                    "drag-canvas",
-                    "zoom-canvas",
-                    "click-select",
-                    "hover",
-                    {
-                        type: "collapse-expand",
-                        trigger: "dblclick",
-                        onChange: (item, collapsed) => {
-                            this.onSelectNode(item.getID());
-                            const data = item.getModel();
-                            data.collapsed = collapsed;
-                            graph.setItemState(item, "collapsed", data.collapsed as boolean);
-                            const icon = data.collapsed ? G6.Marker.expand : G6.Marker.collapse;
-                            const marker = item
-                                .get("group")
-                                .find((ele: any) => ele.get("name") === "collapse-icon");
-                            marker.attr("symbol", icon);
-                            return true;
-                        },
-                    },
-                ],
+                default: ["drag-canvas", "zoom-canvas", "click-select", "hover"],
             },
             defaultEdge: {
                 type: "cubic-horizontal",
@@ -147,6 +168,27 @@ export default class Editor extends React.Component<EditorProps, EditorState> {
             this.isInEditor = false;
         });
 
+        graph.on("node:click", (e: G6GraphEvent) => {
+            if (e.shape.cfg.name === "collapse-icon") {
+                const item = e.item;
+                this.onSelectNode(item.getID());
+                const data = item.getModel();
+                if ((data as unknown as GraphNodeModel).children?.length > 0) {
+                    data.collapsed = !data.collapsed;
+                    graph.setItemState(item, "collapsed", data.collapsed as boolean);
+                    e.shape.attr("symbol", data.collapsed ? G6.Marker.expand : G6.Marker.collapse);
+                    this.graph.layout();
+                }
+            }
+        });
+
+        graph.on("node:dblclick", (e: G6GraphEvent) => {
+            const data = this.findSubtree(e.item.getModel() as unknown as GraphNodeModel);
+            if (data) {
+                this.props.onOpenSubtree(data.path);
+            }
+        });
+
         graph.on("node:mouseenter", (e: G6GraphEvent) => {
             const { item } = e;
             if (item.hasState("selected")) {
@@ -258,15 +300,15 @@ export default class Editor extends React.Component<EditorProps, EditorState> {
 
             const rootData = graph.findDataById("1");
             const srcData = graph.findDataById(srcNodeId) as GraphNodeModel;
-            const srcParent = Utils.findParent(this.graph, srcData);
+            const srcParent = this.findParent(srcData);
             const dstData = graph.findDataById(dstNode.getID()) as GraphNodeModel;
-            const dstParent = Utils.findParent(this.graph, dstData);
+            const dstParent = this.findParent(dstData);
             if (!srcParent) {
                 console.log("no parent!");
                 return;
             }
 
-            if (Utils.isAncestor(this.graph, srcData, dstData)) {
+            if (this.isAncestor(srcData, dstData)) {
                 // 不能将父节点拖到自已的子孙节点
                 console.log("cannot move to child");
                 return;
@@ -379,10 +421,7 @@ export default class Editor extends React.Component<EditorProps, EditorState> {
 
         this.onSelectNode(null);
         this.pushUndoStack();
-        const parentData = Utils.findParent(
-            this.graph,
-            this.graph.findDataById(curNodeId) as GraphNodeModel
-        );
+        const parentData = this.findParent(this.graph.findDataById(curNodeId) as GraphNodeModel);
         parentData.children = parentData.children.filter((e) => e.id != curNodeId);
         this.changeWithoutAnim();
     }
@@ -583,6 +622,7 @@ export default class Editor extends React.Component<EditorProps, EditorState> {
                         {curNode ? (
                             <NodePanel
                                 model={curNode}
+                                isSubtreeNode={this.isSubtreeNode(curNode)}
                                 settings={this.settings}
                                 updateNode={(id, forceUpdate) => {
                                     if (forceUpdate) {
diff --git a/render-process/RegisterNode.ts b/render-process/RegisterNode.ts
index b65f207..444bbce 100644
--- a/render-process/RegisterNode.ts
+++ b/render-process/RegisterNode.ts
@@ -290,21 +290,6 @@ export default function (settings: Settings) {
                     y += 20;
                 }
 
-                if (Array.isArray(cfg.children) && cfg.children.length > 0) {
-                    group.addShape("marker", {
-                        attrs: {
-                            x: w,
-                            y: h / 2,
-                            r: 6,
-                            symbol: G6.Marker.collapse,
-                            stroke: "#666",
-                            lineWidth: 1,
-                            fill: "#fff",
-                        },
-                        name: "collapse-icon",
-                    });
-                }
-
                 group.addShape("rect", {
                     name: "drag-up",
                     attrs: {
@@ -346,6 +331,22 @@ export default function (settings: Settings) {
                     },
                     draggable: true,
                 });
+
+                if (Array.isArray(cfg.children) && cfg.children.length > 0) {
+                    group.addShape("marker", {
+                        attrs: {
+                            x: w,
+                            y: h / 2,
+                            r: 6,
+                            symbol: G6.Marker.collapse,
+                            stroke: "#666",
+                            lineWidth: 1,
+                            fill: "#fff",
+                        },
+                        name: "collapse-icon",
+                    });
+                }
+
                 return shape;
             },
         },
diff --git a/render-process/TreeTabs.tsx b/render-process/TreeTabs.tsx
index 2df783f..99e15c9 100644
--- a/render-process/TreeTabs.tsx
+++ b/render-process/TreeTabs.tsx
@@ -93,12 +93,16 @@ export default class TreeTabs extends Component<TreeTabsProps, TreeTabsState> {
 
         ipcRenderer.on(MainEventType.UNDO, () => {
             const editor = this.getCurEditor();
-            editor?.undo();
+            if (editor?.isInEditor) {
+                editor.undo();
+            }
         });
 
         ipcRenderer.on(MainEventType.REDO, () => {
             const editor = this.getCurEditor();
-            editor?.redo();
+            if (editor?.isInEditor) {
+                editor.redo();
+            }
         });
     }
 
@@ -143,6 +147,10 @@ export default class TreeTabs extends Component<TreeTabsProps, TreeTabsState> {
         trees = trees.filter((tree) => tree.filepath != path);
         const length = trees.length;
         this.setState({ trees: trees, curTree: length > 0 ? trees[0].filepath : null });
+        if (length > 0) {
+            const editor = this.editors[trees[0].filepath];
+            editor?.reload();
+        }
     }
 
     render() {
@@ -184,6 +192,10 @@ export default class TreeTabs extends Component<TreeTabsProps, TreeTabsState> {
                                         this.forceUpdate();
                                     }
                                 }}
+                                onOpenSubtree={(path) => {
+                                    const settings = Utils.getRemoteSettings();
+                                    this.openFile(settings.workdir + "/" + path);
+                                }}
                                 ref={(ref) => {
                                     this.editors[tree.filepath] = ref;
                                 }}
diff --git a/sample/workdir/monster.json b/sample/workdir/monster.json
index 39cbd8c..d675192 100644
--- a/sample/workdir/monster.json
+++ b/sample/workdir/monster.json
@@ -24,6 +24,7 @@
                 "id": 4,
                 "name": "Sequence",
                 "desc": "新建行为树",
+                "args": {},
                 "path": "subtree2.json"
               }
             ]
diff --git a/sample/workdir/subtree2.json b/sample/workdir/subtree2.json
index 9997bcd..9f73205 100644
--- a/sample/workdir/subtree2.json
+++ b/sample/workdir/subtree2.json
@@ -7,6 +7,14 @@
     "children": [
       {
         "id": 2,
+        "name": "Cmp",
+        "args": {},
+        "input": [
+          ""
+        ]
+      },
+      {
+        "id": 3,
         "name": "unknow"
       }
     ]